Conversation
ghost
assigned
|
Don't know why jenkins/pr-merge passes and jenkins/branch doesn't. |
| options = options || {} | ||
|
|
||
| this.broadcast = options.broadcast !== false | ||
| this.interval = options.interval || (1e3 * 10) |
There was a problem hiding this comment.
@richardschneider instead of removing the feature all together, it should support for a single beacon.
There was a problem hiding this comment.
Not really sure why you want a beacon?
interval controlled how often an MDNS query is sent. Every time it is sent, all other IPFS nodes must respond with their DNS records.
There was a problem hiding this comment.
I do not see a need to drop the interval beacon feature. The module should support both, single beacon and interval.
There was a problem hiding this comment.
First off, a beacon is not what MDNS is about. Secondly it can be very expensive.
Consider a data centre with 100 servers all running IPFS with an interval of 10 minutes, or 600 seconds. On average, a node will beacon every 6 seconds. Then every 6 seconds all other nodes must wake-up and reply with their DNS records. All nodes will then see all the nodes responses and have to then .emit discovered nodes. It's a real waste of network bandwidth and CPU.
daviddias
added
status/ready
2 participants
See #70